Author: Manos Pitsidianakis [manos@pitsidianak.is]
Hash: 05333385a821b130e60677cca01a1ff3d65d68c3
Timestamp: Wed, 10 Jan 2024 08:28:31 +0000 (8 months ago)

+7 -11 +/-7 browse
Fix new clippy lints. 
Fix new clippy lints.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1diff --git a/cli/build.rs b/cli/build.rs
2index 568d926..2f0db6d 100644
3--- a/cli/build.rs
4+++ b/cli/build.rs
5 @@ -23,7 +23,7 @@ use std::{
6 io::Write,
7 };
8
9- use clap::ArgAction;
10+ use clap::{ArgAction, CommandFactory};
11 use clap_mangen::{roff, Man};
12 use roff::{bold, italic, roman, Inline, Roff};
13
14 diff --git a/cli/src/args.rs b/cli/src/args.rs
15index 57211f8..8414783 100644
16--- a/cli/src/args.rs
17+++ b/cli/src/args.rs
18 @@ -19,7 +19,7 @@
19
20 pub use std::path::PathBuf;
21
22- pub use clap::{builder::TypedValueParser, Args, CommandFactory, Parser, Subcommand};
23+ pub use clap::{builder::TypedValueParser, Args, Parser, Subcommand};
24
25 #[derive(Debug, Parser)]
26 #[command(
27 diff --git a/core/src/message_filters.rs b/core/src/message_filters.rs
28index ff68d23..553a471 100644
29--- a/core/src/message_filters.rs
30+++ b/core/src/message_filters.rs
31 @@ -42,7 +42,6 @@ mod settings;
32 use log::trace;
33 use melib::{Address, HeaderName};
34 use percent_encoding::utf8_percent_encode;
35- pub use settings::*;
36
37 use crate::{
38 mail::{ListContext, MailJob, PostAction, PostEntry},
39 diff --git a/core/src/models.rs b/core/src/models.rs
40index fe1aaa6..884c966 100644
41--- a/core/src/models.rs
42+++ b/core/src/models.rs
43 @@ -320,7 +320,7 @@ impl MailingList {
44 Address::new(Some(self.name.clone()), self.address.clone())
45 }
46
47- /// List unsubscribe action as a [`MailtoAddress`](super::MailtoAddress).
48+ /// List unsubscribe action as a [`MailtoAddress`].
49 pub fn unsubscription_mailto(&self) -> MailtoAddress {
50 MailtoAddress {
51 address: self.request_subaddr(),
52 @@ -328,7 +328,7 @@ impl MailingList {
53 }
54 }
55
56- /// List subscribe action as a [`MailtoAddress`](super::MailtoAddress).
57+ /// List subscribe action as a [`MailtoAddress`].
58 pub fn subscription_mailto(&self) -> MailtoAddress {
59 MailtoAddress {
60 address: self.request_subaddr(),
61 @@ -336,7 +336,7 @@ impl MailingList {
62 }
63 }
64
65- /// List owner as a [`MailtoAddress`](super::MailtoAddress).
66+ /// List owner as a [`MailtoAddress`].
67 pub fn owner_mailto(&self) -> MailtoAddress {
68 let p = self.address.split('@').collect::<Vec<&str>>();
69 MailtoAddress {
70 diff --git a/core/src/policies.rs b/core/src/policies.rs
71index 432495b..1632653 100644
72--- a/core/src/policies.rs
73+++ b/core/src/policies.rs
74 @@ -19,9 +19,6 @@
75
76 //! How each list handles new posts and new subscriptions.
77
78- pub use post_policy::*;
79- pub use subscription_policy::*;
80-
81 mod post_policy {
82 use log::trace;
83 use rusqlite::OptionalExtension;
84 diff --git a/core/src/postfix.rs b/core/src/postfix.rs
85index 0cb7b05..519f803 100644
86--- a/core/src/postfix.rs
87+++ b/core/src/postfix.rs
88 @@ -67,7 +67,7 @@ pub struct PostfixConfiguration {
89 #[serde(default)]
90 pub process_limit: Option<u64>,
91 /// The directory in which the map files are saved.
92- /// Default is `data_path` from [`Configuration`](crate::Configuration).
93+ /// Default is `data_path` from [`Configuration`].
94 #[serde(default)]
95 pub map_output_path: Option<PathBuf>,
96 /// The name of the Postfix service name to use.
97 diff --git a/web/src/settings.rs b/web/src/settings.rs
98index 20e38fb..13a6736 100644
99--- a/web/src/settings.rs
100+++ b/web/src/settings.rs
101 @@ -276,7 +276,7 @@ pub async fn user_list_subscription(
102 .list_subscription(
103 list.pk(),
104 subscriptions
105- .get(0)
106+ .first()
107 .ok_or_else(|| {
108 ResponseError::new(
109 "Subscription not found".to_string(),